added DC personalities for some meters to affected files#308
Open
dmiskovic-NV wants to merge 11 commits intomlcommons:masterfrom
Open
added DC personalities for some meters to affected files#308dmiskovic-NV wants to merge 11 commits intomlcommons:masterfrom
dmiskovic-NV wants to merge 11 commits intomlcommons:masterfrom
Conversation
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
arjunsuresh
approved these changes
May 19, 2023
Contributor
arjunsuresh
left a comment
arjunsuresh
left a comment
There was a problem hiding this comment.
Thank you Dejan for these changes.
Contributor
Author
|
Please review and merge. All changes needed to get DC running are in this PR |
araghun
previously approved these changes
Nov 21, 2023
Contributor
araghun
left a comment
araghun
left a comment
There was a problem hiding this comment.
Approved as discussed in PowerWG 11/21
dmiskovic-NV
dismissed
araghun’s stale review
The merge-base changed after approval.
araghun
approved these changes
Nov 21, 2023
Contributor
araghun
left a comment
araghun
left a comment
There was a problem hiding this comment.
Approved as discussed in PowerWG 11/21
araghun
previously approved these changes
Nov 21, 2023
Contributor
araghun
left a comment
araghun
left a comment
There was a problem hiding this comment.
Approved as discussed in PowerWG 11/21
Contributor
|
Not sure who has to approve this to be merged. |
dmiskovic-NV
dismissed
araghun’s stale review
The merge-base changed after approval.
araghun
previously approved these changes
Nov 28, 2023
dmiskovic-NV
dismissed
araghun’s stale review
The merge-base changed after approval.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adding changes mentioned in #305